knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.
Apache License 2.0
7 stars 18 forks source link

Skip failing E2E test #259

Closed dsimansk closed 2 years ago

dsimansk commented 2 years ago

There's really an issue with serviceAccount under releases are currently executed. I suspect it's related to signing binaries, hence the service account is changed for that purpose.

This will unblock the release for now.

/cc @rhuss @vyasgun @lionelvillard @nak3

Changes

-

-

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 2 years ago

@dsimansk: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-sandbox/kn-plugin-admin/pull/259): > > > >There's really an issue with serviceAccount under releases are currently executed. I suspect it's related to signing binaries, hence the service account is changed for that purpose. > >This will unblock the release for now. > >/cc @rhuss @vyasgun @lionelvillard @nak3 > ># Changes > > > >- >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dsimansk commented 2 years ago

/cherry-pick release-1.8

knative-prow-robot commented 2 years ago

@dsimansk: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you.

In response to [this](https://github.com/knative-sandbox/kn-plugin-admin/pull/259#issuecomment-1283831009): >/cherry-pick release-1.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow-robot commented 2 years ago

@dsimansk: new pull request created: #260

In response to [this](https://github.com/knative-sandbox/kn-plugin-admin/pull/259#issuecomment-1283831009): >/cherry-pick release-1.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.