Closed navidshaikh closed 3 years ago
/test pull-knative-sandbox-kn-plugin-admin-integration-tests
not sure why github actions unit tests complains
debug stable-window 120s
--- FAIL: TestNewAsUpdateSetCommand (0.04s)
--- FAIL: TestNewAsUpdateSetCommand/return_error_if_scale-to-zero-grace-period_is_not_time_duration (0.01s)
update_test.go:243: assertion failed: expected error to contain "missing unit in duration 60", got "invalid argument \"60\" for \"--scale-to-zero-grace-period\" flag: time: missing unit in duration \"60\"": invalid argument "60" for "--scale-to-zero-grace-period" flag: time: missing unit in duration "60"
FAIL
while the prow unit tests pass :thinking: any idea @zhanggbj ?
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: navidshaikh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
:exclamation: No coverage uploaded for pull request base (
master@700690f
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #28 +/- ##
=========================================
Coverage ? 77.63%
=========================================
Files ? 19
Lines ? 921
Branches ? 0
=========================================
Hits ? 715
Misses ? 152
Partials ? 54
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 700690f...03cd935. Read the comment docs.
/test pull-knative-sandbox-kn-plugin-admin-integration-tests
/close
ported the go-test workflow update in #31
@navidshaikh: Closed this PR.
/hold