knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.

Apache License 2.0

7 stars 18 forks source link

CI was here #28

Closed navidshaikh closed 3 years ago

navidshaikh commented 3 years ago

/hold

navidshaikh commented 3 years ago

/test pull-knative-sandbox-kn-plugin-admin-integration-tests

navidshaikh commented 3 years ago

not sure why github actions unit tests complains

debug stable-window 120s
--- FAIL: TestNewAsUpdateSetCommand (0.04s)
    --- FAIL: TestNewAsUpdateSetCommand/return_error_if_scale-to-zero-grace-period_is_not_time_duration (0.01s)
        update_test.go:243: assertion failed: expected error to contain "missing unit in duration 60", got "invalid argument \"60\" for \"--scale-to-zero-grace-period\" flag: time: missing unit in duration \"60\"": invalid argument "60" for "--scale-to-zero-grace-period" flag: time: missing unit in duration "60"
FAIL

while the prow unit tests pass :thinking: any idea @zhanggbj ?

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/master/OWNERS)~~ [navidshaikh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@700690f). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #28   +/-   ##
=========================================
  Coverage          ?   77.63%           
=========================================
  Files             ?       19           
  Lines             ?      921           
  Branches          ?        0           
=========================================
  Hits              ?      715           
  Misses            ?      152           
  Partials          ?       54

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 700690f...03cd935. Read the comment docs.

navidshaikh commented 3 years ago

/test pull-knative-sandbox-kn-plugin-admin-integration-tests

navidshaikh commented 3 years ago

/close

ported the go-test workflow update in #31

knative-prow-robot commented 3 years ago

@navidshaikh: Closed this PR.

In response to [this](https://github.com/knative-sandbox/kn-plugin-admin/pull/28#issuecomment-740554866): >/close > >ported the go-test workflow update in #31 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.