search

knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.
Apache License 2.0
7 stars 18 forks source link

Bump to go1.15 #30

Closed zhanggbj closed 3 years ago

zhanggbj commented 3 years ago

issue 26

Changes

/kind bug

Fixes #26

Release Note

Docs

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@700690f). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #30   +/-   ##
=========================================
  Coverage          ?   77.63%           
=========================================
  Files             ?       19           
  Lines             ?      921           
  Branches          ?        0           
=========================================
  Hits              ?      715           
  Misses            ?      152           
  Partials          ?       54

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 700690f...4a53ec4. Read the comment docs.

zhanggbj commented 3 years ago

@chaozbj @zhi-gang-sun please help to take a review, this could resolve the prow test failure (UT) due to go 1.5 change and issue #26 ,thanks!

navidshaikh commented 3 years ago

please help to take a review, this could resolve the prow test failure (UT) due to go 1.5 change and issue #26 ,thanks!

The test failure is in github actions tests and we can update it to run the tests with go 1.14 Also, I think we should bump the go version only after the client is updated.

navidshaikh commented 3 years ago

/hold

@zhanggbj PTAL https://github.com/knative-sandbox/kn-plugin-admin/pull/31

zhanggbj commented 3 years ago

@navidshaikh Sounds good. So let's hold this until the kn-client bumped

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/master/OWNERS)~~ [maximilien,zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maximilien commented 3 years ago

Hi, @zhanggbj, wondering why this is not merging?

/lgtm

zhanggbj commented 3 years ago

@maximilien as last time Navid mentioned plugins are better to align with kn client, so have to bump go 1.5 after kn client, so I hold this PR.

knative-prow-robot commented 3 years ago

@zhanggbj: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rhuss commented 3 years ago

@zhanggbj looks good to me, but you have to resolve the conflict first before we can merge

rhuss commented 3 years ago

This can be closed as the update has been added along with #44