Closed zhanggbj closed 3 years ago
:exclamation: No coverage uploaded for pull request base (
master@700690f
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage ? 77.63%
=========================================
Files ? 19
Lines ? 921
Branches ? 0
=========================================
Hits ? 715
Misses ? 152
Partials ? 54
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 700690f...4a53ec4. Read the comment docs.
@chaozbj @zhi-gang-sun please help to take a review, this could resolve the prow test failure (UT) due to go 1.5 change and issue #26 ,thanks!
please help to take a review, this could resolve the prow test failure (UT) due to go 1.5 change and issue #26 ,thanks!
The test failure is in github actions tests and we can update it to run the tests with go 1.14 Also, I think we should bump the go version only after the client is updated.
/hold
@zhanggbj PTAL https://github.com/knative-sandbox/kn-plugin-admin/pull/31
@navidshaikh Sounds good. So let's hold this until the kn-client bumped
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: maximilien, zhanggbj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Hi, @zhanggbj, wondering why this is not merging?
/lgtm
@maximilien as last time Navid mentioned plugins are better to align with kn client, so have to bump go 1.5 after kn client, so I hold this PR.
@zhanggbj: PR needs rebase.
@zhanggbj looks good to me, but you have to resolve the conflict first before we can merge
This can be closed as the update has been added along with #44
issue 26
Changes
/kind bug
Fixes #26
Release Note
Docs