knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.

Apache License 2.0

7 stars 18 forks source link

Update github workflow go test to setup go 1.14 #31

Closed navidshaikh closed 3 years ago

navidshaikh commented 3 years ago

Since unit tests break for go 1.15

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/master/OWNERS)~~ [navidshaikh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

navidshaikh commented 3 years ago

/assign @zhanggbj

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@700690f). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage          ?   77.63%           
=========================================
  Files             ?       19           
  Lines             ?      921           
  Branches          ?        0           
=========================================
  Hits              ?      715           
  Misses            ?      152           
  Partials          ?       54

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 700690f...0a6d62b. Read the comment docs.

zhanggbj commented 3 years ago

@navidshaikh one quick question, there're lots of 1.5.x specified in the following files, is there any thing we need fix in this PR?

https://github.com/knative-sandbox/kn-plugin-admin/search?q=1.15

navidshaikh commented 3 years ago

@zhanggbj : We can update them to 1.14 as well, but the respective checks pass. We'll eventually move to go 1.15 and I'd keep it this way and adjust the required when its time to bump to 1.15.

zhanggbj commented 3 years ago

/lgtm

@navidshaikh if this is the case, I agree and merging this PR.