Closed navidshaikh closed 3 years ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: navidshaikh
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/assign @zhanggbj
:exclamation: No coverage uploaded for pull request base (
master@700690f
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #31 +/- ##
=========================================
Coverage ? 77.63%
=========================================
Files ? 19
Lines ? 921
Branches ? 0
=========================================
Hits ? 715
Misses ? 152
Partials ? 54
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 700690f...0a6d62b. Read the comment docs.
@navidshaikh one quick question, there're lots of 1.5.x specified in the following files, is there any thing we need fix in this PR?
https://github.com/knative-sandbox/kn-plugin-admin/search?q=1.15
@zhanggbj : We can update them to 1.14 as well, but the respective checks pass. We'll eventually move to go 1.15 and I'd keep it this way and adjust the required when its time to bump to 1.15.
/lgtm
@navidshaikh if this is the case, I agree and merging this PR.
Since unit tests break for go 1.15