knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.
Apache License 2.0
7 stars 18 forks source link

Add support for plugin inline feature #38

Closed dsimansk closed 3 years ago

dsimansk commented 3 years ago

Changes

Fixes #37

dsimansk commented 3 years ago

/cc @maximilien please assign appropriately.

navidshaikh commented 3 years ago

Fix unit test - this might be not necessary, but it was failing for me locally

are you running golang 1.15 locally?

dsimansk commented 3 years ago

Fix unit test - this might be not necessary, but it was failing for me locally

are you running golang 1.15 locally?

Yep, that's an issue apparently. I've reverted the "fix" commit.

codecov[bot] commented 3 years ago

Codecov Report

Merging #38 (4b20ec4) into master (eaeb388) will increase coverage by 0.49%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   78.76%   79.26%   +0.49%     
==========================================
  Files          20       20              
  Lines        1003     1032      +29     
==========================================
+ Hits          790      818      +28     
+ Misses        156      155       -1     
- Partials       57       59       +2     
Impacted Files Coverage Δ
pkg/command/profiling/profiling.go 81.85% <0.00%> (-0.50%) :arrow_down:
pkg/command/domain/set.go 96.49% <0.00%> (+0.19%) :arrow_up:
pkg/command/registry/add.go 92.94% <0.00%> (+0.25%) :arrow_up:
pkg/command/autoscaling/list.go 92.85% <0.00%> (+0.26%) :arrow_up:
pkg/command/domain/unset.go 94.11% <0.00%> (+0.56%) :arrow_up:
pkg/command/registry/list.go 87.93% <0.00%> (+0.65%) :arrow_up:
pkg/command/registry/remove.go 77.52% <0.00%> (+0.78%) :arrow_up:
pkg/command/autoscaling/update.go 70.27% <0.00%> (+0.82%) :arrow_up:
pkg/command/domain/list.go 85.18% <0.00%> (+1.85%) :arrow_up:
pkg/types.go 22.00% <0.00%> (+2.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eaeb388...4b20ec4. Read the comment docs.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, maximilien, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/master/OWNERS)~~ [maximilien,navidshaikh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maximilien commented 3 years ago

/lgtm

dsimansk commented 3 years ago

@maximilien @rhuss per WG call yesterday the PR is ready. I'll remove hold because it requires fresh /lgtm anyway.

/unhold

zhanggbj commented 3 years ago

/lgtm