knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.

Apache License 2.0

7 stars 18 forks source link

Add CODE_OF_CONDUCT.md and OWNER_ALIASES #39

Closed navidshaikh closed 3 years ago

navidshaikh commented 3 years ago

Changes

replace toc members in OWNERS file with their alias technical-oversight-committee

as done in https://github.com/knative-sandbox/kn-plugin-source-kafka/pull/15

codecov[bot] commented 3 years ago

Codecov Report

Merging #39 (8a7cfb0) into master (eaeb388) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files          20       20           
  Lines        1003     1003           
=======================================
  Hits          790      790           
  Misses        156      156           
  Partials       57       57

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eaeb388...e89dd7e. Read the comment docs.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: navidshaikh, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/master/OWNERS)~~ [navidshaikh,zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

zhanggbj commented 3 years ago

/lgtm Thanks @navidshaikh !