knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.
Apache License 2.0
7 stars 18 forks source link

refine README to include installation and add release.sh #4

Closed chaozbj closed 4 years ago

chaozbj commented 4 years ago

The following changes are for our first release:

  1. Refine README.doc to include installation part
  2. Add release.sh to build kn-admin for MacOS, Linux and Windows.
  3. Follow the kn client rules to generate version for kn-admin, please see the below examples.

Currently, we still use module knative.dev/client-contrib/plugins/admin as module name in our codes. It is maybe changed because we moved into a new repository. I will keep eyes on that and change the release.sh as the module name is changed.

knative-prow-robot commented 4 years ago

Welcome @chaozbj! It looks like this is your first PR to knative-sandbox/kn-plugin-admin 🎉

knative-prow-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chaozbj, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/master/OWNERS)~~ [rhuss] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment