search

knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.
Apache License 2.0
7 stars 18 forks source link

add missing ut for autoscaling cmd #42

Closed zhanggbj closed 3 years ago

zhanggbj commented 3 years ago

Changes

/kind cleanup

Fixes #

Release Note

Docs

knative-prow-robot commented 3 years ago

@zhanggbj: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them

In response to [this](https://github.com/knative-sandbox/kn-plugin-admin/pull/42): >- add missing ut for autoscaling cmd >- fix ut failure if using go 1.15 > > > ># Changes > > > >- >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 3 years ago

Codecov Report

Merging #42 (a843bf4) into master (3609064) will increase coverage by 0.71%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   79.26%   79.98%   +0.71%     
==========================================
  Files          20       20              
  Lines        1032     1029       -3     
==========================================
+ Hits          818      823       +5     
+ Misses        155      147       -8     
  Partials       59       59
Impacted Files Coverage Δ
pkg/command/autoscaling/autoscaling.go 100.00% <ø> (+100.00%) :arrow_up:
pkg/command/domain/domain.go 100.00% <ø> (ø)
pkg/command/registry/registry.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3609064...5b8d32d. Read the comment docs.

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/master/OWNERS)~~ [maximilien,zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment