Closed rhuss closed 3 years ago
/hold
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent.
in this pull request.
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla
label to yes
(if enabled on your project).
ℹ️ Googlers: Go here for more info.
@googlebot I consent.
Merging #44 (c1f8e1e) into master (a1036dd) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #44 +/- ##
=======================================
Coverage 79.98% 79.98%
=======================================
Files 20 20
Lines 1029 1029
=======================================
Hits 823 823
Misses 147 147
Partials 59 59
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a1036dd...8441ab5. Read the comment docs.
/retest
@rhuss one of the assert seems to failing due to different error format. Do you mind if I push one more commit?
@rhuss and test setup needs update too. https://github.com/knative-sandbox/kn-plugin-admin/blob/master/test/e2e-tests.sh#L25-L26
@rhuss one of the assert seems to failing due to different error format. Do you mind if I push one more commit?
go ahead !
/lgtm
@rhuss: you cannot LGTM your own PR.
@dsimansk sorry, forget to answer: If you can quickly fix the assertions, that would be great (and push then). Otherwise I can do it later, too
/lgtm /approve
@rhuss: you cannot LGTM your own PR.
/lgtm
/unhold
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dsimansk, mattmoor, maximilien, rhuss
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Includes update to go 1.15 and alignment of dependencies for kn 0.21
/hold until pkg-source is released (remove the last replace in go.mod then)