search

knative-extensions / kn-plugin-admin

Kn plugin for managing a Kubernetes based Knative installation.
Apache License 2.0
7 stars 18 forks source link

Installation method detect #5

Closed xliuxu closed 3 years ago

xliuxu commented 4 years ago

Detect installation method and return error for domain/autoscaling update operations if installed by KnativeOperator. In future domain/autoscaling update command should be able to handle operator mode.

knative-prow-robot commented 4 years ago

Welcome @lanceliuu! It looks like this is your first PR to knative-sandbox/kn-plugin-admin 🎉

xliuxu commented 3 years ago

@zhanggbj Just added two negative test cases for update command. PTAL.

zhanggbj commented 3 years ago

/approve /lgtm @lanceliuu Thanks for the PR 👍 Merging it!

knative-prow-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lanceliuu, zhanggbj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-admin/blob/master/OWNERS)~~ [zhanggbj] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment