Closed 12345lcr closed 3 years ago
Welcome @12345lcr! It looks like this is your first PR to knative-sandbox/kn-plugin-admin 🎉
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
@12345lcr Thanks for the PR! Looks good and I just left one comment about the package. Thanks!
/approve /lgtm Thanks @12345lcr for your PR👍 Merging it.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: 12345lcr, zhanggbj
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Fixed: https://github.com/knative-sandbox/kn-plugin-admin/issues/6
imagePullSecret