knative-extensions / kn-plugin-event

Kn plugin for sending events to Knative sinks.
Apache License 2.0
7 stars 22 forks source link

:bug: Delete successful job with background propagation policy #241

Closed cardil closed 1 year ago

cardil commented 1 year ago

Changes

/kind bug

Fixes #228

Release Note

:bug: Sending event using in-cluster sender no longer display a Warn about propagation policy
cardil commented 1 year ago

/assign @rhuss /assign @dsimansk /cc @mgencur /cc @jrangelramos

codecov[bot] commented 1 year ago

Codecov Report

Merging #241 (358dd53) into main (dc74d72) will increase coverage by 0.08%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   67.97%   68.06%   +0.08%     
==========================================
  Files          35       35              
  Lines        1121     1124       +3     
==========================================
+ Hits          762      765       +3     
  Misses        299      299              
  Partials       60       60              
Impacted Files Coverage Δ
pkg/k8s/jobrunner.go 69.00% <100.00%> (+0.95%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cardil commented 1 year ago

/assign @vyasgun

cardil commented 1 year ago

/test integration-tests

The Kservice test variant is flaky. It looks like a regression in Serving.

cardil commented 1 year ago

/test integration-tests

The Kservice test variant is flaky.

https://testgrid.k8s.io/r/knative-own-testgrid/kn-plugin-event#continuous

cardil commented 1 year ago

/test integration-tests

The Kservice test variant is flaky: https://github.com/knative-sandbox/kn-plugin-event/issues/242

dsimansk commented 1 year ago

/approve /lgtm

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-event/blob/main/OWNERS)~~ [cardil,dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cardil commented 1 year ago

/cherrypick release-1.8

knative-prow-robot commented 1 year ago

@cardil: new pull request created: #245

In response to [this](https://github.com/knative-sandbox/kn-plugin-event/pull/241#issuecomment-1291778091): >/cherrypick release-1.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.