search

knative-extensions / kn-plugin-event

Kn plugin for sending events to Knative sinks.
Apache License 2.0
7 stars 22 forks source link

[release-1.8] :bug: Delete successful job with background propagation policy #245

Closed knative-prow-robot closed 2 years ago

knative-prow-robot commented 2 years ago

This is an automated cherry-pick of #241

:bug: Sending event using in-cluster sender no longer display a Warn about propagation policy
knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-event/blob/release-1.8/OWNERS)~~ [cardil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 2 years ago

Codecov Report

Merging #245 (88f1a6b) into release-1.8 (359dd4b) will increase coverage by 0.08%. The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-1.8     #245      +/-   ##
===============================================
+ Coverage        67.97%   68.06%   +0.08%     
===============================================
  Files               35       35              
  Lines             1121     1124       +3     
===============================================
+ Hits               762      765       +3     
  Misses             299      299              
  Partials            60       60
Impacted Files Coverage Δ
pkg/k8s/jobrunner.go 69.00% <100.00%> (+0.95%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cardil commented 2 years ago

/test integration-tests

The InClusterSender/KnativeService is flaky :crying_cat_face: https://github.com/knative-sandbox/kn-plugin-event/issues/242

cardil commented 2 years ago

/test integration-tests

The InClusterSender/KnativeService is flaky :crying_cat_face: https://github.com/knative-sandbox/kn-plugin-event/issues/242

cardil commented 2 years ago

/test integration-tests

The InClusterSender/KnativeService is flaky :crying_cat_face: https://github.com/knative-sandbox/kn-plugin-event/issues/242