knative-extensions / kn-plugin-event

Kn plugin for sending events to Knative sinks.

Apache License 2.0

7 stars 22 forks source link

Replace knative.dev/client references with knative.dev/client-pkg #255

Closed vyasgun closed 1 year ago

vyasgun commented 1 year ago

Changes

Replaced the occurrences of knative.dev/client with knative.dev/client-pkg
A few dependencies upgraded during the build which caused a field change in eventingv1.BrokerStatus. I updated the code accordingly in addressresolver_cases.go.

/kind cleanup

Part of https://github.com/knative/client/issues/1591

Release Note

Docs

codecov[bot] commented 1 year ago

Codecov Report

Merging #255 (7990dd5) into main (5b799ab) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files          35       35           
  Lines        1128     1128           
=======================================
  Hits          769      769           
  Misses        299      299           
  Partials       60       60

Impacted Files	Coverage Δ
pkg/cli/target.go	`48.57% <ø> (ø)`
pkg/plugin/plugin.go	`100.00% <ø> (ø)`
pkg/plugin/testing.go	`94.44% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evankanderson, vyasgun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-event/blob/main/OWNERS)~~ [evankanderson] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment