search

knative-extensions / kn-plugin-event

Kn plugin for sending events to Knative sinks.
Apache License 2.0
7 stars 22 forks source link

[release-1.9] :bug: Bumping knative.dev/hack to latest main #269

Closed cardil closed 1 year ago

cardil commented 1 year ago

Changes

/kind bug

Fixes https://github.com/knative-sandbox/homebrew-kn-plugins/issues/134

Release Note

Fixing the invalid checksums on MacOS platform, for release-1.9, making homebrew install work again.
cardil commented 1 year ago

@upodroid here's my plan:

In this PR I've manually bumped the knative.dev/hack to latest main. After this PR lands, and we do a dot-release for kn-event, and confirm all signatures and checksums are calculated properly, we could go ahead with cherry-picking the https://github.com/knative/hack/pull/268 to release-1.9 branch. After that, we can fix all other affected repos (with update-deps PR and a dot-release).

cardil commented 1 year ago

/cc @upodroid /cc @kvmware

codecov[bot] commented 1 year ago

Codecov Report

Merging #269 (b8fb9a3) into release-1.9 (9e98e75) will not change coverage. The diff coverage is n/a.

@@             Coverage Diff              @@
##           release-1.9     #269   +/-   ##
============================================
  Coverage        68.17%   68.17%           
============================================
  Files               35       35           
  Lines             1128     1128           
============================================
  Hits               769      769           
  Misses             299      299           
  Partials            60       60

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-event/blob/release-1.9/OWNERS)~~ [cardil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cardil commented 1 year ago

/hold cancel

Fix confirmed, see: https://github.com/knative-sandbox/kn-plugin-event/pull/270#issuecomment-1427899908