search

knative-extensions / kn-plugin-event

Kn plugin for sending events to Knative sinks.
Apache License 2.0
7 stars 22 forks source link

Fix broken checksums generation #270

Closed upodroid closed 1 year ago

upodroid commented 1 year ago

/cc @cardil

Lets merge this, run the nightly then download the files and check before cutting a release.

gsutil cp -r gs://knative-nightly/kn-plugin-event/latest .
cd latest && sha256sum --check --ignore-missing checksums.txt
codecov[bot] commented 1 year ago

Codecov Report

Merging #270 (b0c1023) into main (2226de2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files          35       35           
  Lines        1128     1128           
=======================================
  Hits          769      769           
  Misses        299      299           
  Partials       60       60

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-sandbox/kn-plugin-event/blob/main/OWNERS)~~ [cardil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cardil commented 1 year ago

Nightly build triggered: https://prow.knative.dev/view/gs/knative-prow/logs/nightly_kn-plugin-event_main_periodic/1625103373835440128

cardil commented 1 year ago

@upodroid I think it looks good:

$ gsutil cp -r gs://knative-nightly/kn-plugin-event/latest .                                                                                   
Copying gs://knative-nightly/kn-plugin-event/latest/checksums.txt...
Copying gs://knative-nightly/kn-plugin-event/latest/checksums.txt.pem...        
Copying gs://knative-nightly/kn-plugin-event/latest/checksums.txt.sig...        
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-darwin-amd64...    
| [4 files][ 57.5 MiB/ 57.5 MiB]                                                
==> NOTE: You are performing a sequence of gsutil operations that may
run significantly faster if you instead use gsutil -m cp ... Please
see the -m section under "gsutil help options" for further information
about when gsutil -m can be advantageous.

Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-darwin-arm64...
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-amd64...     
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-arm64...     
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-ppc64le...   
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-s390x...     
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-windows-amd64...   
- [10 files][398.9 MiB/398.9 MiB]   35.6 MiB/s                                  
Operation completed over 10 objects/398.9 MiB.

$ cd latest && sha256sum --check --ignore-missing checksums.txt
kn-event-linux-amd64: OK
kn-event-linux-arm64: OK
kn-event-linux-ppc64le: OK
kn-event-linux-s390x: OK
kn-event-darwin-amd64: OK
kn-event-darwin-arm64: OK
kn-event-windows-amd64: OK
upodroid commented 1 year ago

Thanks