search

knative-extensions / kn-plugin-event

Kn plugin for sending events to Knative sinks.
Apache License 2.0
7 stars 22 forks source link

Use knative.dev/reconciler-test/pkg/resources/service.AsDestinationRef for test/e2e/broker.go@89 #271

Closed cardil closed 1 year ago

cardil commented 1 year ago

Check failure on line 89 in test/e2e/broker.go:

SA1019: svc.AsDestinationRef is deprecated: use knative.dev/reconciler-test/pkg/resources/service.AsDestinationRef  (staticcheck)

Code:

https://github.com/knative-sandbox/kn-plugin-event/blob/bbb9afa1d7f7dede1d04452695298f9db7d353f8/test/e2e/broker.go#L89

This issue is blocking PRs, like: https://github.com/knative-sandbox/kn-plugin-event/pull/268#issuecomment-1427418539

/kind bug