search

knative-extensions / kn-plugin-event

Kn plugin for sending events to Knative sinks.
Apache License 2.0
7 stars 22 forks source link

Updating RetryableHttp lib to latest #359

Closed matzew closed 2 months ago

matzew commented 2 months ago

Changes

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 2 months ago

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/kn-plugin-event/pull/359): ># Changes > > > >- :broom: Update to latet of the retryable http lib > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
matzew commented 2 months ago

/assign @cardil

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.67%. Comparing base (e25c85c) to head (21d1f96).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #359 +/- ## ======================================= Coverage 55.67% 55.67% ======================================= Files 51 51 Lines 1374 1374 ======================================= Hits 765 765 Misses 540 540 Partials 69 69 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/kn-plugin-event/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
matzew commented 2 months ago

/cherry-pick 1.14

matzew commented 2 months ago

/cherry-pick release-1.14

matzew commented 2 months ago

/cherry-pick release-1.13

knative-prow-robot commented 2 months ago

@matzew: cannot checkout 1.14: error checking out "1.14": exit status 1 error: pathspec '1.14' did not match any file(s) known to git

In response to [this](https://github.com/knative-extensions/kn-plugin-event/pull/359#issuecomment-2191754280): >/cherry-pick 1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 2 months ago

@matzew: new pull request created: #360

In response to [this](https://github.com/knative-extensions/kn-plugin-event/pull/359#issuecomment-2191754632): >/cherry-pick release-1.14 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 2 months ago

@matzew: #359 failed to apply on top of branch "release-1.13":

Applying: Updating RetryableHttp lib to latest
Using index info to reconstruct a base tree...
M   build/go.mod
M   build/go.sum
M   go.mod
M   go.sum
M   go.work.sum
Falling back to patching base and 3-way merge...
Auto-merging go.work.sum
CONFLICT (content): Merge conflict in go.work.sum
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging build/go.sum
CONFLICT (content): Merge conflict in build/go.sum
Auto-merging build/go.mod
CONFLICT (content): Merge conflict in build/go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Updating RetryableHttp lib to latest
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/knative-extensions/kn-plugin-event/pull/359#issuecomment-2191754834): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.