knative-extensions / kn-plugin-event

Kn plugin for sending events to Knative sinks.
Apache License 2.0
7 stars 22 forks source link

:gift_heart: Migrating to sink flag for --to param #368

Closed cardil closed 1 month ago

cardil commented 1 month ago

Changes

/kind enhancement

Relations

Fixes #282 Fixes #202 Fixes #356 Fixes #160 Requires https://github.com/knative/client/pull/1968

Release Notes

Target for the sending is now done excusivly with --to param, which follows the standard for Kn sink format.
The kubernetes related parameters have been aligned to be on par with Kn.

Docs

TBD
knative-prow[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

cardil commented 1 month ago

/test all

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 79.70149% with 68 lines in your changes missing coverage. Please review.

Project coverage is 69.26%. Comparing base (f9cb9aa) to head (da9f541). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/k8s/params.go 0.00% 17 Missing :warning:
pkg/cli/target.go 56.25% 13 Missing and 1 partial :warning:
internal/cli/send.go 72.22% 7 Missing and 3 partials :warning:
pkg/k8s/addressresolver.go 76.19% 4 Missing and 1 partial :warning:
pkg/k8s/kubeclient.go 82.14% 3 Missing and 2 partials :warning:
pkg/sender/binding.go 78.26% 3 Missing and 2 partials :warning:
internal/cli/root.go 95.12% 1 Missing and 1 partial :warning:
pkg/binding/memoized.go 81.81% 1 Missing and 1 partial :warning:
pkg/k8s/test/addressresolver_cases.go 88.88% 1 Missing and 1 partial :warning:
pkg/sender/in_cluster.go 75.00% 2 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #368 +/- ## =========================================== + Coverage 55.67% 69.26% +13.58% =========================================== Files 51 48 -3 Lines 1374 1246 -128 =========================================== + Hits 765 863 +98 + Misses 540 313 -227 - Partials 69 70 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cardil commented 1 month ago

/test all

knative-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/kn-plugin-event/blob/main/OWNERS)~~ [cardil,dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cardil commented 1 month ago

@dsimansk Would you mind reviewing https://github.com/knative-extensions/kn-plugin-event/pull/368/commits/da9f541b6692a42034713d660ee0f1192e8c7110, as well?

I added the above as the PR suppose to fix https://github.com/knative-extensions/kn-plugin-event/issues/356

dsimansk commented 1 month ago

/lgtm