search

knative-extensions / kn-plugin-event

Kn plugin for sending events to Knative sinks.
Apache License 2.0
7 stars 22 forks source link

:bug: Reset KUBERNETES env variables to ensure there's no Kube connection for unit test #379

Closed cardil closed 2 weeks ago

cardil commented 2 weeks ago

Changes

/kind bug

Fixes #378

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.52%. Comparing base (a6872a8) to head (2206804). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #379 +/- ## ======================================= Coverage 66.52% 66.52% ======================================= Files 48 48 Lines 1440 1440 ======================================= Hits 958 958 Misses 412 412 Partials 70 70 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

knative-prow[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, dsimansk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/kn-plugin-event/blob/main/OWNERS)~~ [cardil,dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment