knative-extensions / kn-plugin-quickstart

Kn plugin for installation of Knative cluster for developers to quickstart.
Apache License 2.0
24 stars 38 forks source link

Adding a new Minikube flag for helm chart install of Apache Camel K #521

Closed matzew closed 5 months ago

matzew commented 5 months ago

Changes

/kind

Fixes #

Release Note

Docs

knative-prow[bot] commented 5 months ago

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/kn-plugin-quickstart/pull/521): ># Changes > > > >- :gift: Add new feature for Apache Camel K install, for allowing advanced Knative Eventing samples > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
matzew commented 5 months ago

How to test this PR?

Once all installed, run a simple example, such as kamelet as source.

Convenience manifest for all bits:

apiVersion: eventing.knative.dev/v1
kind: Broker
metadata:
  namespace: default
  name: kamelet-source
---
apiVersion: v1
kind: Service
metadata:
  name: kamelet-receiver-function
spec:
  selector:
    app: kamelet-receiver-function
  ports:
    - port: 80
      protocol: TCP
      targetPort: http
      name: http
---
apiVersion: v1
kind: Pod
metadata:
  name: kamelet-receiver-function
  labels:
    app: kamelet-receiver-function
spec:
  securityContext:
    runAsNonRoot: true
    seccompProfile:
      type: RuntimeDefault
  containers:
  - name: kamelet-receiver-function
    securityContext:
      allowPrivilegeEscalation: false
      readOnlyRootFilesystem: true
      runAsNonRoot: true
      capabilities:
        drop:
        - ALL
      seccompProfile:
        type: RuntimeDefault
    image: registry.ci.openshift.org/openshift/knative-eventing-event-display:knative-nightly
    imagePullPolicy: Always
    ports:
    - containerPort: 8080
      protocol: TCP
      name: http
---
apiVersion: eventing.knative.dev/v1
kind: Trigger
metadata:
  name: trigger
spec:
  broker: kamelet-source
  subscriber:
    ref:
      apiVersion: v1
      kind: Service
      name: kamelet-receiver-function
---
apiVersion: camel.apache.org/v1
kind: Pipe
metadata:
  name: beer-source-pipe
spec:
  source:
    ref:
      kind: Kamelet
      apiVersion: camel.apache.org/v1
      name: beer-source
  sink:
    properties:
      cloudEventsType: com.corp.my.beer.source
    ref:
      kind: Broker
      apiVersion: eventing.knative.dev/v1
      name: kamelet-source
Leo6Leo commented 5 months ago
{"level":"error","ts":"2024-06-19T15:31:45Z","msg":"Reconciler error","controller":"kamelet-binding-controller","object":{"name":"beer-source-pipe","namespace":"default"},"namespace":"default","name":"beer-source-pipe","reconcileID":"a8133d24-2ce3-4784-aae1-571a44299a09","error":"could not determine sink URI: integration referencing Knative endpoint 'kamelet-source' that cannot run, because Knative is not installed on the cluster","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.15.2/pkg/internal/controller/controller.go:324\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.15.2/pkg/internal/controller/controller.go:265\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\tsigs.k8s.io/controller-runtime@v0.15.2/pkg/internal/controller/controller.go:226"}

After applying the pipe yaml, camel-operator is complaining "Knative is not installed".

So only one thing: the testing command should add --install-serving flag: ./kn-quickstart minikube --install-serving --install-eventing --install-camel!

Other than that, all the resources become ready and I can see events showing up in the receiver function log too! @matzew

matzew commented 5 months ago

nope.

can you update your helm chart and try again? That serving issues was fixed by camel

-M

Sent from Gmail Mobile

On Wed 19. Jun 2024 at 17:42, Leo Li @.***> wrote:

{"level":"error","ts":"2024-06-19T15:31:45Z","msg":"Reconciler error","controller":"kamelet-binding-controller","object":{"name":"beer-source-pipe","namespace":"default"},"namespace":"default","name":"beer-source-pipe","reconcileID":"a8133d24-2ce3-4784-aae1-571a44299a09","error":"could not determine sink URI: integration referencing Knative endpoint 'kamelet-source' that cannot run, because Knative is not installed on the @.**@*.**@*./pkg/internal/controller/controller.go:226 @*.**@*.**@./pkg/internal/controller/controller.go:226>"}

After applying the pipe yaml, camel-operator is complaining "Knative is not installed".

So only one thing: the testing command should add --install-serving flag: ./kn-quickstart minikube --install-serving --install-eventing --install-camel!

Other than that, all the resources become ready and I can see events showing up in the receiver function log too! @matzew https://github.com/matzew

— Reply to this email directly, view it on GitHub https://github.com/knative-extensions/kn-plugin-quickstart/pull/521#issuecomment-2179006839, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGPTUS6DMVSULN2VEIYK3ZIGRE7AVCNFSM6AAAAABJBZ2X36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGAYDMOBTHE . You are receiving this because you were mentioned.Message ID: @.***>

Leo6Leo commented 5 months ago

nope. can you update your helm chart and try again? That serving issues was fixed by camel -M Sent from Gmail Mobile On Wed 19. Jun 2024 at 17:42, Leo Li @.> wrote: {"level":"error","ts":"2024-06-19T15:31:45Z","msg":"Reconciler error","controller":"kamelet-binding-controller","object":{"name":"beer-source-pipe","namespace":"default"},"namespace":"default","name":"beer-source-pipe","reconcileID":"a8133d24-2ce3-4784-aae1-571a44299a09","error":"could not determine sink URI: integration referencing Knative endpoint 'kamelet-source' that cannot run, because Knative is not installed on the @*.**@*.**@./pkg/internal/controller/controller.go:226 @.**@*.**@*./pkg/internal/controller/controller.go:226>"} After applying the pipe yaml, camel-operator is complaining "Knative is not installed". So only one thing: the testing command should add --install-serving flag: ./kn-quickstart minikube --install-serving --install-eventing --install-camel! Other than that, all the resources become ready and I can see events showing up in the receiver function log too! @matzew https://github.com/matzew — Reply to this email directly, view it on GitHub <#521 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABGPTUS6DMVSULN2VEIYK3ZIGRE7AVCNFSM6AAAAABJBZ2X36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGAYDMOBTHE . You are receiving this because you were mentioned.Message ID: @.>

It works out after upgrading the helm chart. Thanks! @matzew Now I can say that all the resources become ready and I can see events showing up in the receiver function log with minikube.

dsimansk commented 5 months ago

/approve /lgtm

knative-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/kn-plugin-quickstart/blob/main/OWNERS)~~ [dsimansk] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment