Closed chzhyang closed 1 year ago
Merging #338 (264d30f) into main (2d661cd) will decrease coverage by
1.08%
. The diff coverage is44.00%
.
@@ Coverage Diff @@
## main #338 +/- ##
==========================================
- Coverage 50.34% 49.27% -1.08%
==========================================
Files 13 13
Lines 2014 2145 +131
==========================================
+ Hits 1014 1057 +43
- Misses 935 1018 +83
- Partials 65 70 +5
Impacted Files | Coverage Δ | |
---|---|---|
pkg/command/service/scale.go | 30.04% <41.93%> (-3.85%) |
:arrow_down: |
pkg/command/service/common.go | 50.11% <45.45%> (-2.06%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chzhyang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thank you for the PR. It's useful to loop the cold startup latency test for some times to get more precise result. Will you update the correspnding documents for the updates?
Thanks, addressed, docs will be updated soon.
Changes
updateAllowZeroInitialScale()
configs allow-zero-initial-scale in configmaps/config-autoscaler before scale up, and restore it after scale upupdateKsvc()
configs stable window and initial scaleDocs
generate two knative service for test:
kperf service generate -n 2 -b 1 -c 1 -i 10 --namespace default --svc-prefix ktest
time-interval
> stable window(6s is the minimal value) + cold startup latency of workload(2s~4s, helloworld-go in kperf) , so I recommand to set time-interval=10stest:
kperf service scale --namespace default --svc-prefix ktest --range 0,2 --verbose --output /tmp -i 20 -T 10s -s 6s