knative-extensions / net-contour

A Knative ingress controller for Project Contour

Apache License 2.0

31 stars 52 forks source link

Add CORS policy to config-contour #1069

Closed izabelacg closed 4 months ago

izabelacg commented 5 months ago

Changes

add corsPolicy property to config-contour to allow corsPolicy configuration flow into HTTPProxies

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.92%. Comparing base (820cd7c) to head (469bedc). Report is 6 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1069 +/- ## ========================================== - Coverage 94.06% 93.92% -0.14% ========================================== Files 11 11 Lines 893 708 -185 ========================================== - Hits 840 665 -175 + Misses 32 22 -10 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

izabelacg commented 5 months ago

/hold for others to review

krsna-m commented 5 months ago

/unhold

dprotaso commented 4 months ago

See the check

Code Style / style / Golang / Auto-format and Check

dprotaso commented 4 months ago

thanks 🎉 /lgtm /approve

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/net-contour/blob/main/OWNERS)~~ [dprotaso,izabelacg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment