search

knative-extensions / net-contour

A Knative ingress controller for Project Contour
Apache License 2.0
31 stars 52 forks source link

Bump Contour to v1.28.2 #1072

Closed izabelacg closed 4 months ago

izabelacg commented 4 months ago

Changes

Resolves #1068

izabelacg commented 4 months ago

/hold for others

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.69%. Comparing base (820cd7c) to head (8480309). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1072 +/- ## ========================================== - Coverage 94.06% 93.69% -0.37% ========================================== Files 11 11 Lines 893 682 -211 ========================================== - Hits 840 639 -201 + Misses 32 22 -10 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 4 months ago

/lgtm /approve

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/net-contour/blob/main/OWNERS)~~ [dprotaso,izabelacg] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 4 months ago

/hold cancel

dprotaso commented 4 months ago

Error from server (InternalError): error when retrieving current configuration of: Resource: "/v1, Resource=namespaces", GroupVersionKind: "/v1, Kind=Namespace" Name: "contour-external", Namespace: "" from server for: "STDIN": an error on the server ("Internal Server Error: \"/api/v1/namespaces/contour-external\": the server is currently unable to handle the request") has prevented the request from succeeding (get namespaces contour-external)

ugh GKE

/retest