search

knative-extensions / net-contour

A Knative ingress controller for Project Contour
Apache License 2.0
31 stars 52 forks source link

[release-1.14] Set CORS policy values only for when HTTPProxy associated with external visibility #1089

Closed knative-prow-robot closed 3 months ago

knative-prow-robot commented 3 months ago

This is an automated cherry-pick of #1088

Apply CORS policy on external routes
dprotaso commented 3 months ago

/lgtm /approve

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/net-contour/blob/release-1.14/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (release-1.14@fc93044). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.14 #1089 +/- ## =============================================== Coverage ? 93.92% =============================================== Files ? 11 Lines ? 708 Branches ? 0 =============================================== Hits ? 665 Misses ? 22 Partials ? 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.