knative-extensions / net-contour

A Knative ingress controller for Project Contour

Apache License 2.0

31 stars 52 forks source link

add e2e tests for CORS feature #1100

Closed izabelacg closed 2 months ago

izabelacg commented 3 months ago

Changes

:broom: add e2e tests for CORS feature

/kind cleanup

Fixes https://github.com/knative/serving/issues/15226

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: izabelacg Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/knative-extensions/net-contour/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.92%. Comparing base (69cd1a9) to head (32e48b9). Report is 4 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1100 +/- ## ======================================= Coverage 93.92% 93.92% ======================================= Files 11 11 Lines 708 708 ======================================= Hits 665 665 Misses 22 22 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

izabelacg commented 2 months ago

We'll stick to unit tests instead.