knative-extensions / net-contour

A Knative ingress controller for Project Contour
Apache License 2.0
31 stars 52 forks source link

fix system internal encryption #1110

Closed dprotaso closed 2 months ago

dprotaso commented 2 months ago

This uses the new SANs and certificate.

Fixes: https://github.com/knative-extensions/net-contour/issues/703

Release Note

Fixes system-internal-encryption by using the updated activator and workload subject alternate names
knative-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/net-contour/blob/main/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 2 months ago

/assign @ReToCode

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.96%. Comparing base (b1718e4) to head (c318bab).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1110 +/- ## ========================================== + Coverage 93.92% 93.96% +0.03% ========================================== Files 11 11 Lines 708 712 +4 ========================================== + Hits 665 669 +4 Misses 22 22 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

izabelacg commented 2 months ago

/lgtm