knative-extensions / net-contour

A Knative ingress controller for Project Contour
Apache License 2.0
31 stars 52 forks source link

Add support for cluster local tls #1112

Closed dprotaso closed 4 months ago

dprotaso commented 4 months ago

Part of: https://github.com/knative/serving/issues/14375

Release Note

Add support for cluster-local-tls routes
dprotaso commented 4 months ago

/assign @izabelacg @ReToCode

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.01%. Comparing base (b28a029) to head (defb126). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1112 +/- ## ========================================== + Coverage 93.96% 94.01% +0.05% ========================================== Files 11 11 Lines 712 719 +7 ========================================== + Hits 669 676 +7 Misses 22 22 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

skonto commented 4 months ago

Some unchanged files have header issues.

dprotaso commented 4 months ago

Some unchanged files have header issues.

I'll do that in a separate PR - done https://github.com/knative-extensions/net-contour/pull/1114

skonto commented 4 months ago

LGTM waiting for @ReToCode and @izabelacg

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/net-contour/blob/main/OWNERS)~~ [ReToCode,dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment