search

knative-extensions / net-contour

A Knative ingress controller for Project Contour
Apache License 2.0
31 stars 52 forks source link

Failed to create Knative Service #605

Open dprotaso opened 3 years ago

dprotaso commented 3 years ago

net-contour get's into a weird state when I try to create a service with a single character name

kn service create a --image gcr.io/knative-samples/helloworld-go --env TARGET=A

The logs show

HTTPProxy.projectcontour.io \"a--ep-contour-internal-6baf84cb4382b42fab34fb571f9b82a9a-00001.\" is invalid: metadata.name: Invalid value: \"a--ep-contour-internal-6baf84cb4382b42fab34fb571f9b82a9a-00001.\": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

It seems like it should actually be valid based on the regex - https://regex101.com/r/KiCvWq/1

Either way since we can't create the HTTPProxy we should probably set Ready=False on the Ingress to bubble this up that the Service failed

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

dprotaso commented 2 years ago

/lifecycle frozen