search

knative-extensions / net-gateway-api

Integration between Knative and service-apis (ingress v2) for Knative Ingress migration.
Apache License 2.0
24 stars 28 forks source link

Add TestHTTPOption for gateway-api #130

Open nak3 opened 2 years ago

nak3 commented 2 years ago

knative networking repo added a new test as https://github.com/knative/networking/pull/415.

And 0.4.0-rc1 should support this filter https://github.com/kubernetes-sigs/gateway-api/commit/e4536a0f5a41e9b71436b30603548cebf36896c0

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

ReToCode commented 1 year ago

To summarise, this issue could be done with the current gateway-api spec, but it is a bit verbose (see the PR: https://github.com/knative-sandbox/net-gateway-api/pull/437). So before we merge it, we are waiting to see what https://github.com/kubernetes-sigs/gateway-api/issues/1185 will bring for version 0.7.0 of the spec (https://github.com/knative-sandbox/net-gateway-api/pull/437#issuecomment-1396977713).

dprotaso commented 2 weeks ago

Just an FYI - I tried to see if there was interest in simplifying this upstream.

I didn't get the votes https://github.com/kubernetes-sigs/gateway-api/discussions/3103#discussioncomment-9739590 so it's not going to be in 1.2 (Sept). So the earliest it could land now if it was part of 1.3 would be next year.

I'm thinking we go ahead with the verbose approach