search

knative-extensions / net-gateway-api

Integration between Knative and service-apis (ingress v2) for Knative Ingress migration.
Apache License 2.0
24 stars 28 forks source link

Contour External has ExternalName Services Support #638

Open dprotaso opened 4 months ago

dprotaso commented 4 months ago

In theory we don't need this since serving can handle returning an IP address via the KIngress

https://github.com/knative-extensions/net-gateway-api/blob/0e92b90271098f28518ed0292abac863a2acfbce/third_party/contour/gateway-external.yaml#L38-L39

KauzClay commented 2 months ago

/assign

dprotaso commented 2 months ago

Note: If we set the IP address in KIngress Status then serving will use it properly

https://github.com/knative/serving/pull/11843

dprotaso commented 2 months ago

https://github.com/knative/networking/blob/1d9a7cfb2ee119e581ba164fa1d152889efcf8a1/pkg/apis/networking/v1alpha1/ingress_types.go#L303

KauzClay commented 2 months ago

/unassign

oops, I meant to assign myself to this one: https://github.com/knative-extensions/net-gateway-api/issues/665