search

knative-extensions / net-gateway-api

Integration between Knative and service-apis (ingress v2) for Knative Ingress migration.
Apache License 2.0
27 stars 28 forks source link

Bump Gateway API v1.1 #734

Closed dprotaso closed 4 months ago

dprotaso commented 4 months ago

Trying to redo - https://github.com/knative-extensions/net-gateway-api/pull/729

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/net-gateway-api/blob/main/OWNERS)~~ [dprotaso] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.12%. Comparing base (f8ed9a7) to head (8cd0a8b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #734 +/- ## ======================================= Coverage 79.12% 79.12% ======================================= Files 17 17 Lines 1260 1260 ======================================= Hits 997 997 Misses 227 227 Partials 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dprotaso commented 4 months ago

/test integration-tests-contour_net-gateway-api_main

dprotaso commented 4 months ago

/assign @izabelacg

This is ready - but the diff is too large so a bunch of checks fail - we can ignore those. For me the main thing is the integration tests pass.

izabelacg commented 4 months ago

/lgtm

dprotaso commented 4 months ago

Overriding broken jobs - diff is to large and reviewdog breaks

/override "style / Golang / Lint" /override "style / Golang / Do Not Submit" /override "style / Golang / Boilerplate Check (go)" /override "style / Golang / Boilerplate Check (sh)" /override "style / suggester / shell" /override "codecov/patch"

knative-prow[bot] commented 4 months ago

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/knative-extensions/net-gateway-api/pull/734#issuecomment-2142839434): >Overriding broken jobs - diff is to large and reviewdog breaks > >/override "style / Golang / Lint" >/override "style / Golang / Do Not Submit" >/override "style / Golang / Boilerplate Check (go)" >/override "style / Golang / Boilerplate Check (sh)" >/override "style / suggester / shell" >/override "codecov/patch" > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dprotaso commented 4 months ago

/override "patch"

knative-prow[bot] commented 4 months ago

@dprotaso: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/knative-extensions/net-gateway-api/pull/734#issuecomment-2142843244): >/override "patch" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dprotaso commented 4 months ago

/override "style / Golang / Lint" /override "style / Golang / Do Not Submit" /override "style / Golang / Boilerplate Check (go)" /override "style / Golang / Boilerplate Check (sh)" /override "style / suggester / shell"

knative-prow[bot] commented 4 months ago

@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Boilerplate Check (go), style / Golang / Boilerplate Check (sh), style / Golang / Do Not Submit, style / Golang / Lint, style / suggester / shell

In response to [this](https://github.com/knative-extensions/net-gateway-api/pull/734#issuecomment-2142851301): >/override "style / Golang / Lint" >/override "style / Golang / Do Not Submit" >/override "style / Golang / Boilerplate Check (go)" >/override "style / Golang / Boilerplate Check (sh)" >/override "style / suggester / shell" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.