knative-extensions / net-kourier

Purpose-built Knative Ingress implementation using just Envoy with no additional CRDs
Apache License 2.0
290 stars 80 forks source link

Increase gateway memory limit #1236

Closed ReToCode closed 3 months ago

ReToCode commented 3 months ago

Changes

Fixes https://github.com/knative/serving/issues/15052

Release Note

The default memory limit of 3scale-kourier-gateway was increased to prevent OOMKilled on peak load scenarios
knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/net-kourier/blob/main/OWNERS)~~ [ReToCode] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ReToCode commented 3 months ago

/assign @skonto

Tested in https://github.com/knative/serving/pull/15060.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.31%. Comparing base (3655396) to head (6da3cc4). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1236 +/- ## ========================================== + Coverage 60.63% 62.31% +1.67% ========================================== Files 24 24 Lines 2002 1632 -370 ========================================== - Hits 1214 1017 -197 + Misses 726 553 -173 Partials 62 62 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

skonto commented 3 months ago

/lgtm

skonto commented 3 months ago

Do we know why we need this increase (besides flakes), what is the root cause of the overhead?

ReToCode commented 3 months ago

That we added more stuff to encryption, we are definitely creating more envoy config with this (thus, just the tls test were flaky).