search

knative-extensions / reconciler-test

Behaviour driven reconciler testing framework.
Apache License 2.0
29 stars 38 forks source link

fix: eventshub receiver does not panic when rejecting event for bad format #752

Open Cali0707 opened 1 month ago

Cali0707 commented 1 month ago

The eventshub receiver panics when rejecting an event due to the wrong format as the status code has not been set, leading to writing a status code of 0.

Changes

knative-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/reconciler-test/blob/main/OWNERS)~~ [Cali0707] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Cali0707 commented 1 month ago

/cc @pierDipi @creydr