search

knative-extensions / serving-progressive-rollout

Knative Serving extension to roll out the revision progressively
Apache License 2.0
6 stars 7 forks source link

In the final stage, scaling-up finishes first #110

Closed houshengbo closed 7 months ago

houshengbo commented 7 months ago

Fixed: #84

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/serving-progressive-rollout/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 24.00000% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 50.20%. Comparing base (af1dc85) to head (d5d7825).

Files Patch % Lines
pkg/reconciler/service/service.go 27.27% 16 Missing :warning:
...g/apis/serving/v1/rolloutorchestrator_lifecycle.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #110 +/- ## ========================================== - Coverage 50.44% 50.20% -0.25% ========================================== Files 23 23 Lines 2226 2245 +19 ========================================== + Hits 1123 1127 +4 - Misses 1060 1076 +16 + Partials 43 42 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.