search

knative-extensions / serving-progressive-rollout

Knative Serving extension to roll out the revision progressively
Apache License 2.0
6 stars 7 forks source link

[release-1.13] In the final stage, scaling-up finishes first #113

Closed knative-prow-robot closed 7 months ago

knative-prow-robot commented 7 months ago

This is an automated cherry-pick of #107

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 50.33%. Comparing base (f8cf5d2) to head (7b90487).

Files Patch % Lines
pkg/reconciler/service/service.go 40.00% 12 Missing :warning:
...g/apis/serving/v1/rolloutorchestrator_lifecycle.go 0.00% 3 Missing :warning:
...onciler/rolloutorchestrator/rolloutorchestrator.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.13 #113 +/- ## ================================================ - Coverage 50.44% 50.33% -0.12% ================================================ Files 23 23 Lines 2226 2235 +9 ================================================ + Hits 1123 1125 +2 - Misses 1060 1068 +8 + Partials 43 42 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 7 months ago

/lgtm /approve

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/serving-progressive-rollout/blob/release-1.13/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment