search

knative-extensions / serving-progressive-rollout

Knative Serving extension to roll out the revision progressively
Apache License 2.0
6 stars 7 forks source link

Added the service conversion and RolloutDuration check #116

Closed houshengbo closed 7 months ago

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/serving-progressive-rollout/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 37.77778% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 49.84%. Comparing base (4f4de5c) to head (98836a8). Report is 1 commits behind head on main.

Files Patch % Lines
pkg/reconciler/service/service.go 24.00% 19 Missing :warning:
pkg/reconciler/service/config.go 55.00% 7 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #116 +/- ## ========================================== - Coverage 50.33% 49.84% -0.50% ========================================== Files 23 23 Lines 2235 2261 +26 ========================================== + Hits 1125 1127 +2 - Misses 1068 1090 +22 - Partials 42 44 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yuzisun commented 7 months ago

/lgtm

houshengbo commented 7 months ago

/cherry-pick release-1.13

knative-prow-robot commented 7 months ago

@houshengbo: new pull request created: #117

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/116#issuecomment-1983751123): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.