knative-extensions / serving-progressive-rollout

Knative Serving extension to roll out the revision progressively
Apache License 2.0
6 stars 7 forks source link

Clean up the SPA when revision is deleted #163

Closed houshengbo closed 5 months ago

houshengbo commented 5 months ago

Changes

/kind

Fixes #162

Release Note

Docs

knative-prow[bot] commented 5 months ago

@houshengbo: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/163): > > > > ># Changes > > > >- >- >- > > >/kind > > >Fixes # > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
knative-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/serving-progressive-rollout/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 13.79310% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 51.98%. Comparing base (5c8bcbb) to head (6f38784). Report is 13 commits behind head on main.

Files Patch % Lines
...onciler/rolloutorchestrator/rolloutorchestrator.go 14.81% 23 Missing :warning:
pkg/reconciler/rolloutorchestrator/controller.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #163 +/- ## ========================================== + Coverage 49.42% 51.98% +2.55% ========================================== Files 23 23 Lines 2280 1764 -516 ========================================== - Hits 1127 917 -210 + Misses 1109 802 -307 - Partials 44 45 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.