knative-extensions / serving-progressive-rollout

Knative Serving extension to roll out the revision progressively
Apache License 2.0
6 stars 7 forks source link

Implementation of the resourceUtil mode for the progressive rollout #167

Closed houshengbo closed 5 months ago

houshengbo commented 5 months ago

Fixed: #160

knative-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/serving-progressive-rollout/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 33.20312% with 171 lines in your changes are missing coverage. Please review.

Project coverage is 48.83%. Comparing base (5c8bcbb) to head (7ed6ef5). Report is 20 commits behind head on main.

Files Patch % Lines
...onciler/rolloutorchestrator/strategies/strategy.go 0.00% 139 Missing :warning:
.../reconciler/rolloutorchestrator/strategies/base.go 79.59% 18 Missing and 2 partials :warning:
...onciler/rolloutorchestrator/rolloutorchestrator.go 0.00% 8 Missing :warning:
pkg/reconciler/rolloutorchestrator/controller.go 0.00% 3 Missing :warning:
pkg/reconciler/service/service.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #167 +/- ## ========================================== - Coverage 49.42% 48.83% -0.60% ========================================== Files 23 25 +2 Lines 2280 1894 -386 ========================================== - Hits 1127 925 -202 + Misses 1109 924 -185 - Partials 44 45 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 5 months ago

/cherry-pick release-1.13

knative-prow-robot commented 5 months ago

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/167#issuecomment-2097180836): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yuzisun commented 5 months ago

/lgtm

knative-prow-robot commented 5 months ago

@houshengbo: new pull request created: #173

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/167#issuecomment-2097180836): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.