search

knative-extensions / serving-progressive-rollout

Knative Serving extension to roll out the revision progressively
Apache License 2.0
6 stars 7 forks source link

[release-1.13] Clean up the SPA when revision is deleted #168

Closed knative-prow-robot closed 5 months ago

knative-prow-robot commented 5 months ago

This is an automated cherry-pick of #165

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 13.33333% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 51.86%. Comparing base (ddf75b0) to head (e5570fa). Report is 4 commits behind head on release-1.13.

Files Patch % Lines
...onciler/rolloutorchestrator/rolloutorchestrator.go 14.28% 24 Missing :warning:
pkg/reconciler/rolloutorchestrator/controller.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-1.13 #168 +/- ## ================================================ + Coverage 49.42% 51.86% +2.43% ================================================ Files 23 23 Lines 2280 1770 -510 ================================================ - Hits 1127 918 -209 + Misses 1109 807 -302 - Partials 44 45 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 5 months ago

/lgtm /approve

knative-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/serving-progressive-rollout/blob/release-1.13/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment