search

knative-extensions / serving-progressive-rollout

Knative Serving extension to roll out the revision progressively
Apache License 2.0
3 stars 6 forks source link

Refactored the functions cleanUpSPAs and resetObsoleteSPAs #186

Closed houshengbo closed 2 months ago

knative-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/serving-progressive-rollout/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
houshengbo commented 2 months ago

/cherry-pick release-1.13

knative-prow-robot commented 2 months ago

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/186#issuecomment-2121479142): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
houshengbo commented 2 months ago

/cherry-pick release-1.14

knative-prow-robot commented 2 months ago

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/186#issuecomment-2121479201): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 2 months ago

@houshengbo: new pull request created: #187

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/186#issuecomment-2121479201): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 2 months ago

@houshengbo: new pull request created: #188

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/186#issuecomment-2121479142): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.