search

knative-extensions / serving-progressive-rollout

Knative Serving extension to roll out the revision progressively
Apache License 2.0
6 stars 7 forks source link

Updated the status before returning nil in reconcile #192

Closed houshengbo closed 4 months ago

houshengbo commented 4 months ago

Fixes: #193

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/serving-progressive-rollout/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 47.72%. Comparing base (7ac0552) to head (16d00e5). Report is 1 commits behind head on main.

Files Patch % Lines
...onciler/rolloutorchestrator/strategies/strategy.go 0.00% 16 Missing :warning:
...onciler/rolloutorchestrator/rolloutorchestrator.go 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #192 +/- ## ========================================== - Coverage 48.12% 47.72% -0.40% ========================================== Files 25 25 Lines 1943 1959 +16 ========================================== Hits 935 935 - Misses 961 977 +16 Partials 47 47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 4 months ago

/cherry-pick release-1.13

knative-prow-robot commented 4 months ago

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/192#issuecomment-2130358810): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
houshengbo commented 4 months ago

/cherry-pick release-1.14

knative-prow-robot commented 4 months ago

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/192#issuecomment-2130358930): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 4 months ago

@houshengbo: new pull request created: #195

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/192#issuecomment-2130358810): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 4 months ago

@houshengbo: new pull request created: #196

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/192#issuecomment-2130358930): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.