search

knative-extensions / serving-progressive-rollout

Knative Serving extension to roll out the revision progressively
Apache License 2.0
6 stars 7 forks source link

Fixed the issue of equality check between initialRevs and targetRevs #207

Closed houshengbo closed 4 months ago

houshengbo commented 4 months ago

Two arrays of the TargetRevision the should be considered equal regardless of the fields URL and Tag.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.99%. Comparing base (052ea16) to head (032df21). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #207 +/- ## ========================================== + Coverage 47.72% 47.99% +0.26% ========================================== Files 25 25 Lines 1959 1969 +10 ========================================== + Hits 935 945 +10 Misses 977 977 Partials 47 47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 4 months ago

/cherry-pick release-1.13

knative-prow-robot commented 4 months ago

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/207#issuecomment-2155030380): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
houshengbo commented 4 months ago

/cherry-pick release-1.14

knative-prow-robot commented 4 months ago

@houshengbo: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/207#issuecomment-2155030505): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
yuzisun commented 4 months ago

/lgtm /approve

knative-prow[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/serving-progressive-rollout/blob/main/OWNERS)~~ [houshengbo,yuzisun] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
knative-prow-robot commented 4 months ago

@houshengbo: new pull request created: #208

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/207#issuecomment-2155030380): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
knative-prow-robot commented 4 months ago

@houshengbo: new pull request created: #209

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/207#issuecomment-2155030505): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.