knative-extensions / serving-progressive-rollout

Knative Serving extension to roll out the revision progressively

Apache License 2.0

6 stars 7 forks source link

Added the target revisions scaling down into the Spec.StageTargetRevisions #215

Closed houshengbo closed 2 months ago

houshengbo commented 3 months ago

Changes

If over-consumption-ratio is set to 100, add the initial revisions or the revisions in the status into Spec.StageTargetRevisions, marking them as scaling down.
If there is only one pod running for the old revision, there is nothing to improve, as the DeletionTimestamp is not available for the pod, we cannot force-delete the pod. Kubernetes in this case, may take longer time to add the DeletionTimestamp.

/kind

Fixes #191

Release Note

Docs

knative-prow[bot] commented 3 months ago

@houshengbo: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/215): > > > > ># Changes > > > >- >- >- > > >/kind > > >Fixes #191 > > > >**Release Note** > > >```release-note > >``` > >**Docs** > > >```docs > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

knative-prow[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/serving-progressive-rollout/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.76%. Comparing base (be39f4d) to head (9b193e4). Report is 2 commits behind head on main.

Files	Patch %	Lines
pkg/reconciler/service/service.go	88.88%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #215 +/- ## ========================================== + Coverage 47.99% 48.76% +0.76% ========================================== Files 25 25 Lines 1969 1977 +8 ========================================== + Hits 945 964 +19 + Misses 977 966 -11 Partials 47 47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

houshengbo commented 2 months ago

/cherry-pick release-1.14

knative-prow-robot commented 2 months ago

@houshengbo: new pull request created: #218

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/215#issuecomment-2246674772): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.