search

knative-extensions / serving-progressive-rollout

Knative Serving extension to roll out the revision progressively
Apache License 2.0
6 stars 7 forks source link

In the final stage, scaling-up finishes first #91

Closed houshengbo closed 7 months ago

houshengbo commented 7 months ago

Fixed: #84

knative-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative-extensions/serving-progressive-rollout/blob/main/OWNERS)~~ [houshengbo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 17.39130% with 19 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (main@daa1c07). Click here to learn what that means. Report is 3 commits behind head on main.

Files Patch % Lines
pkg/reconciler/service/service.go 20.00% 16 Missing :warning:
...g/apis/serving/v1/rolloutorchestrator_lifecycle.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #91 +/- ## ======================================= Coverage ? 50.15% ======================================= Files ? 23 Lines ? 2243 Branches ? 0 ======================================= Hits ? 1125 Misses ? 1076 Partials ? 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yuzisun commented 7 months ago

/lgtm

houshengbo commented 7 months ago

/cherry-pick release-1.13

knative-prow-robot commented 7 months ago

@houshengbo: new pull request created: #97

In response to [this](https://github.com/knative-extensions/serving-progressive-rollout/pull/91#issuecomment-1977014774): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.