search

knative / actions

Apache License 2.0
11 stars 22 forks source link

Parse added files only for reviewdog #132

Closed krsna-m closed 1 year ago

krsna-m commented 1 year ago

Changes

reviewdog would have to have the changed files variable passed to each tool otherwise with the files changed which might be vendor files which is a problem. The beginning logic of the suggester handles the changed files fine and has a wider scope.

krsna-m commented 1 year ago

problem can be seen here https://github.com/knative/func/actions/runs/4619624235/jobs/8168624810

dprotaso commented 1 year ago

/lgtm /approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/actions/blob/main/OWNERS)~~ [dprotaso,kvmware] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment