knative / actions

Apache License 2.0

11 stars 22 forks source link

Avoid failing if vulnerabilities are found #136

Closed skonto closed 1 year ago

skonto commented 1 year ago

Changes

govulncheck breaks other repos such test/infra since it returns a non zero value if vulnerabilities are found. PR that fails here. Also it does not support silencing (https://pkg.go.dev/golang.org/x/vuln/cmd/govulncheck) or some option to avoid failures if vulnerability is not triggered by a call. So here we always return success in order to get at least the reports. In the future we might want to get more strict.
related discussion.

skonto commented 1 year ago

cc @evankanderson I think we need to relax this :shrug:

krsna-m commented 1 year ago

/lgtm

krsna-m commented 1 year ago

/approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kvmware, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/actions/blob/main/OWNERS)~~ [kvmware] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment