knative / actions

Apache License 2.0

11 stars 22 forks source link

Shell style action enhancements #149

Closed kauana closed 1 year ago

kauana commented 1 year ago

Changes

Don't run the shell style actions in the vendor directory

Pass the reporter config to action-shfmt as a reviewdog_flags config to prevent the following warning:

Warning: Unexpected input(s) 'reporter', valid inputs are ['github_token', 'workdir', 'level', 'filter_mode', 'fail_on_error', 'reviewdog_flags', 'shfmt_flags']

Fixes #145

kauana commented 1 year ago

/assign @kvmware

krsna-m commented 1 year ago

/lgtm /approve

knative-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kauana, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/actions/blob/main/OWNERS)~~ [kvmware] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

krsna-m commented 1 year ago

THANK YOU!!!!