knative / actions

Apache License 2.0
11 stars 22 forks source link

Add token field to codecov config #211

Closed dsimansk closed 6 months ago

dsimansk commented 6 months ago

Changes

Part of the story discussed on Slack and to be discussed on Productivity WG meeting.

This a placeholder fix if we decide to proceed with org wide CODECOV_TOKEN to fix coverage uploads from main branches.

/cc @cardil @upodroid /hold

upodroid commented 6 months ago

I can add an orgwide codecov token. pls send it to me via Slack

dsimansk commented 6 months ago

I can add an orgwide codecov token. pls send it to me via Slack

Thanks! It seems with TOC I have the same level of permissions. So if we give it a green light, I can do it on my end.

dsimansk commented 6 months ago

I can add an orgwide codecov token. pls send it to me via Slack

Thanks! It seems with TOC I have the same level of permissions. So if we give it a green light, I can do it on my end.

@upodroid I've adde token to both orgs respectivelly.

dsimansk commented 6 months ago

/unhold

knative-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/actions/blob/main/OWNERS)~~ [dsimansk,upodroid] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment