search

knative / actions

Apache License 2.0
11 stars 22 forks source link

Bug in style action #83

Closed gabo1208 closed 2 years ago

gabo1208 commented 2 years ago

golangci lint action does not work currently wih go1.19, adjust go version to 1.18 for it to work

More context here: https://github.com/golangci/golangci-lint-action/issues/532

krsna-m commented 2 years ago

/lgtm

krsna-m commented 2 years ago

/approve

knative-prow[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabo1208, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/knative/actions/blob/main/OWNERS)~~ [kvmware] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dprotaso commented 2 years ago

I think this broken the style action in a different way

https://github.com/knative/serving/actions/runs/3386695185/jobs/5626430807

dprotaso commented 2 years ago

Unless my goimports is out of date

dprotaso commented 2 years ago

no there's something else

  Running [/home/runner/golangci-lint-1.46.2-linux-amd64/golangci-lint run --out-format=github-actions --go=1.18] in [] ...
  panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt